search

mitreid-connect / OpenID-Connect-Java-Spring-Server

An OpenID Connect reference implementation in Java on the Spring platform.
Other
1.47k stars 767 forks source link

Upgrade to Java 11 and Spring 5 #1570

Closed shrexster42 closed 2 years ago

shrexster42 commented 2 years ago

Changes to upgrade codebase from spring 4.X to spring 5.X and from Java8 to Java11. The overall project structure remains the same.

Please review and let me know if anything needs to be corrected. Thanks!

jricher commented 2 years ago

This looks like the cleanest version of the update that I've seen done so far -- thank you for this. I think the CI needs to be updated to get Travis CI to run against Java 11 instead of Java 8. But other than that, have you tested and run this code?

shrexster42 commented 2 years ago

Hi @jricher, Thanks for the review. I have included the change to .travis.yml to point to oraclejdk11 from oraclejdk8.

yes, I have tested and run the code and don't see any issues. We have also been running a port of the codebase with Spring 5 and Java 11 for several months now and haven't come across any problems.

jricher commented 2 years ago

Thank you once again for this upgrade, hopefully this helps people running it on more updated systems.