mitro-co / mitro

Repository for all Mitro client & server code
GNU General Public License v3.0
1.64k stars 242 forks source link

Hi {firstname}: Error in mail system #24

Closed pstn closed 9 years ago

pstn commented 10 years ago

I just discovered what looks like a missing '$' or something like this in your mail system. The error is seems only visible when you view the mail in a text only mail client like mutt. I got the following mail:

From: Mitro team@mitro.co
To: XXXXXXXXX
Date: Thu, 31 Jul 2014 17:26:25 +0000
Subject: Congratulations on saving your first secret!

Hi {firstname},

Congratulations on adding your first secret to Mitro!

Did you know you can even access it on your phone?
Get our free mobile app today:

Android: https://play.google.com/store/apps/details?id=co.mitro.mitro

iPhone: https://itunes.apple.com/ms/app/mitro-password-manager/id726427383

-The Mitro team


Mitro is the easiest way to share access to your accounts securely.

https://www.mitro.co

Tweet us at @MitroCo

Jwpe commented 10 years ago

Can confirm this is the case in all emails. It just doesn't show up on the rendered email, but if you look at the email source:

Hi {firstname},

Congratulations on adding your first secret to Mitro!

Did you know you can even access it on your phone?
Get our free mobile app today:

Android: https://play.google.com/store/apps/details?id=co.mitro.mitro

iPhone: https://itunes.apple.com/ms/app/mitro-password-manager/id726427383

-The Mitro team

Had a bit of a look and the template in question is a Mandrill template MANDRILL_SAVE_FIRST_SECRET, as referenced here. Are these in the codebase, or stored directly on Mandrill?

vijayp commented 10 years ago

These are actually on Mandrill and I don't believe they're checked in. This should be pretty simple to fix in the template ...

On Sun, Aug 3, 2014 at 12:03 PM, Jonathan Evans notifications@github.com wrote:

Can confirm this is the case in all emails. It just doesn't show up on the rendered email, but if you look at the email source:

Hi {firstname},

Congratulations on adding your first secret to Mitro!

Did you know you can even access it on your phone? Get our free mobile app today:

Android: https://play.google.com/store/apps/details?id=co.mitro.mitro

iPhone: https://itunes.apple.com/ms/app/mitro-password-manager/id726427383

-The Mitro team

Had a bit of a look and the template in question is a Mandrill template, as referenced here https://github.com/mitro-co/mitro/blob/master/mitro-core/java/server/src/co/mitro/core/server/data/DBEmailQueue.java#L233. Are these in the codebase, or stored directly on Mandrill?

— Reply to this email directly or view it on GitHub https://github.com/mitro-co/mitro/issues/24#issuecomment-50994274.

jerbob92 commented 10 years ago

I'm also missing the toolset to send mails, I see some "auth/emailer2.py" in the Ansible configuration. I can't find this script anywhere. Should I make a new issue for this?

evanj commented 10 years ago

Oh yeah, I forgot about that. That is in a separate repository that contains some older code that is unrelated. I'll export that piece as a separate chunk of code. I've created issue #35 to remind myself :)

pstn commented 9 years ago

The project seems dead.