search

mitro-co / mitro

Repository for all Mitro client & server code
GNU General Public License v3.0
1.64k stars 242 forks source link

(In Progress) Port Makefile to grunt #84

Closed bgw closed 6 years ago

bgw commented 10 years ago

I'm referring to the stuff in browser-ext, of course. It's just hard to get that across in a 50-character summary line.

I don't expect this to be merged yet. I want to get feedback.

The Makefile is really hard to understand (for me at least), so I'm taking a stab at porting it to grunt. This is a rough first iteration, and doesn't result result in a working build (yet). It shows that we could accomplish many of the things we use make for, and (hopefully) in a cleaner fashion. It also uses various third-party grunt modules to replace the functionality of many helper scripts, like mustache_render.js.

For this first iteration, I tried not to modify any of the source tree, but in the long run, this could lay the foundation for further improvements, like downloading most/all dependencies from npm or bower.

Let me know what you think works, and what doesn't. If you think this is the wrong direction and feel that SCons is the javascript build system of the future, let me know that too.

I don't think Make is evil/boring/uncool. Quite the opposite. I just feel like this project has long-since outgrown it.

denadai2 commented 10 years ago

(I appreciate it)

bgw commented 9 years ago

Sorry about the huge diff caused by deleting/moving around third-party libraries causes. Until we remove them from git, it might make sense to use the .gitattributes file to treat all third-party libraries as binaries. I'll make a separate PR for it.

PR #91 also suffers this problem.

bgw commented 6 years ago

Abandoning.