search

mitro-co / mitro

Repository for all Mitro client & server code
GNU General Public License v3.0
1.64k stars 242 forks source link

fixed Firefox popup size issue #89

Open denadai2 opened 10 years ago

denadai2 commented 10 years ago

Fixes #40

denadai2 commented 10 years ago

To explain better this issue: the popup was displaying the web version, with huge problems of usability. This is a temporarily fix in order to make the extension working in Firefox browsers in Linux systems.

(Why is the popup spaced 7px from the border?)

oderwat commented 10 years ago

Is that fixing Windows 7 FF 33 too? I just saw that this is still not working. I was just concerned about OSX which got a fix some weeks ago.

denadai2 commented 10 years ago

I think yes, but I can't try it :((

oderwat commented 10 years ago

I think I still have a buildable copy (where I could apply your patch) on my development system and a win7 vm. I may try it later tonight.

denadai2 commented 10 years ago

nice

denadai2 commented 9 years ago

Fixes #96

cvladan commented 9 years ago

Will someone merge this? Please! This pull request is "sleeping" for more than 2 months, and it looks like it solved a HUGE BUG on Firefox.

Is anybody using Firefox at all, anymore?

Please, faster

denadai2 commented 9 years ago

^^ http://danluu.com/discourage-oss/

kafene commented 9 years ago

I couldn't get the extension to build on my machine, so I edited the code right in my firefox profile folder since the PR was only 4 characters, and it works for me.

teh commented 9 years ago

ping.

Would it make sense to fork this and take over maintenance?

denadai2 commented 9 years ago

then we would not have any official release :)