mitro-co / mitro

Repository for all Mitro client & server code
GNU General Public License v3.0
1.64k stars 242 forks source link

The Firefox client does nothing #96

Open forteller opened 9 years ago

forteller commented 9 years ago

On my Ubuntu Gnome machine the Mitro Firefox extention does nothing useful. It just opens a box where it shows the Mitro websites, with absolutely no secrets. I've tried in many versions of Firefox, but it's always the same. Mitro is not a viable sollution until this is fixed. Thanks!

Please see attached screenshot screenshot at 02-16-20

vijayp commented 9 years ago

strange; what version of ff?

forteller commented 9 years ago

Currently I'm using 34, but it's been like this with all versions of Firefox I've tried it on.

wjam commented 9 years ago

I'm also experiencing this issue on the latest nightly (Linux). Here is a stacktrace that appears in the browser console when opening the extension while logged in:

TypeError: document.getElementById(...) is null
Stack trace:
updateLoginState/</</</<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/____/.mozilla/firefox/egzrgc5a.Temp/extensions/compatibility@addons.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://mitro-login-manager-at-jetpack/mitro-login-manager/data/js/popup.js:4:335
Client.prototype.setMethod/this[a]</<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/____/.mozilla/firefox/egzrgc5a.Temp/extensions/compatibility@addons.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://mitro-login-manager-at-jetpack/mitro-login-manager/data/js/client.js:13:299
Client/this.processIncoming@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/____/.mozilla/firefox/egzrgc5a.Temp/extensions/compatibility@addons.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://mitro-login-manager-at-jetpack/mitro-login-manager/data/js/client.js:2:226
ExtensionHelper/this.bindClient/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/____/.mozilla/firefox/egzrgc5a.Temp/extensions/compatibility@addons.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://mitro-login-manager-at-jetpack/mitro-login-manager/data/js/helpers.js:7:411
onEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/____/.mozilla/firefox/egzrgc5a.Temp/extensions/compatibility@addons.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:45:22
onChromeEvent@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///home/____/.mozilla/firefox/egzrgc5a.Temp/extensions/compatibility@addons.mozilla.org.xpi!/bootstrap.js -> resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/loader/sandbox.js -> resource://gre/modules/commonjs/sdk/content/content-worker.js:91:16

Also note that when not logged in, the box that appears is also different:

mitrologgedout

wjam commented 9 years ago

I believe this will be fixed by PR #89 and is a duplicate of issue #40

antitoxic commented 9 years ago

Same here, Latest firefox on Fedora 21.

denadai2 commented 9 years ago

@wjam is correct :)

vijayp commented 9 years ago

Are there any pending PRs required to make this work or is the latest published version correct?

On Wednesday, February 25, 2015, Marco De Nadai notifications@github.com wrote:

@wjam https://github.com/wjam is correct :)

— Reply to this email directly or view it on GitHub https://github.com/mitro-co/mitro/issues/96#issuecomment-75922015.

winstonhong commented 9 years ago

Hello Folks.

I have tested Ubuntu14.04/Firefox 37, Windows 7/Firefox 37, Ubuntu14.04/Chrome 42, and Windows 7/Chrome 42.

I confirm that this issue has been fixed by denadai2.

@vijayp, I confirm that the two PRs by denadai2 for this commit is still pending.