search

mitsuba-renderer / drjit

Dr.Jit — A Just-In-Time-Compiler for Differentiable Rendering
BSD 3-Clause "New" or "Revised" License
603 stars 45 forks source link

Add missing mulhi_scalar() #189

Closed jeongseok-meta closed 1 year ago

jeongseok-meta commented 1 year ago

This PR addresses #188 that mulhi_scalar() is missing when it's called within array_utils.h:

https://github.com/mitsuba-renderer/drjit/blob/c71ebb792c88abf2460e296e213cbcb8069388a8/include/drjit/array_utils.h#L293

which was previously defined in Enoki's array_fallbacks.h.

njroussel commented 1 year ago

Hi @jeongseok-meta

Indeed, this seems like a code path that was lost to time.

I am confused with your suggestion. Wouldn't it be enough to replace the call to mulhi_scalar to mulhi? Your implementation does the same thing. I feel like I'm missing a small but important detail.

jeongseok-meta commented 1 year ago

Yes, you're right. I've replaced the call from mulhi_scalar to mulhi. Thanks for pointing it out.