Closed dvicini closed 1 year ago
LGTM, thanks! All of this special-casing around matrices will disappear in the nanobind_v2 rewrite. (they switched to row-major order and are therefore just like any another recursively nested array).
Sounds good, I was already expecting that but thought it's still good to have this preliminary fix in the meantime :)
There is a small bug when converting Matrix43f (e.g., an RGB Mueller matrix) to NumPy.
In the current master, such a conversion doesn't quite work. Printing an identity matrix produces the following output:
But it should be
This commit fixes this by slightly generalizing the existing stride recomputation.