Closed njroussel closed 5 months ago
Thank you! I left a few comments.
@wjakob I've added one more commit: https://github.com/mitsuba-renderer/drjit/pull/220/commits/9d0557ef7bb897c2316371411dff8ae77213a38c will block any attempt to use the ndarray
interface when constructing Dr.Jit types from other Dr.Jit types. As discussed, this is typically undesirable because it loses gradient tracking. (I ran into this pretty quickly with Mitsuba :disappointed: )
Perfect, that looks like the right place to make that change.
Various changes:
allclose
handles inf comparisonsdr.identity
UInt32
binary_search
fixedcopysign
fixedarray & active
onDiffArray
typesThese are small changes that have been stacking up from @rtabbara and I. Would be good to get them in before it grows into an ever larger mix of independent fixes.