Various fixes & improvements

njroussel commented 5 months ago

Various changes:

allclose handles inf comparisons
added dr.identity
handle reinterpreting pointer type as UInt32
handle numpy (or otherwise) scalar arithmetic with JIT array
binary_search fixed
copysign fixed
fix for initializations of scalar drjit arrays from other scalar drjit arrays
allow array & active on DiffArray types
minor formatting

These are small changes that have been stacking up from @rtabbara and I. Would be good to get them in before it grows into an ever larger mix of independent fixes.

wjakob commented 5 months ago

Thank you! I left a few comments.

njroussel commented 5 months ago

@wjakob I've added one more commit: https://github.com/mitsuba-renderer/drjit/pull/220/commits/9d0557ef7bb897c2316371411dff8ae77213a38c will block any attempt to use the ndarray interface when constructing Dr.Jit types from other Dr.Jit types. As discussed, this is typically undesirable because it loses gradient tracking. (I ran into this pretty quickly with Mitsuba :disappointed: )

wjakob commented 5 months ago

Perfect, that looks like the right place to make that change.

mitsuba-renderer / drjit

Various fixes & improvements #220