search

mitsuba-renderer / mitsuba-blender

Mitsuba integration add-on for Blender
BSD 3-Clause "New" or "Revised" License
280 stars 37 forks source link

Mesh refactor #63

Closed bathal1 closed 11 months ago

bathal1 commented 1 year ago

Description

This PR addresses compatibility issues caused by data layout changes in Blender's mesh representation for the exporter add-on. With these changes, the exporter should now support versions 3.4 and 3.5 of Blender, which should make it easier to support the upcoming LTS version.

The mesh layout in blender is progressively moving from an array of structs to a struct of arrays format (more detail here, so we need to reflect those changes when interpreting blender data pointers in the mesh exporter.

This PR fixes #58 . In order for these changes to be fully reflected in the exporter, we would need to have a new release of the Mitsuba PyPI package and update the dependency in the addon.

jmoraispk commented 1 year ago

Hey @bathal1 Any update here? Mitstuba in blender 3.6 would be fantastic! :)

bathal1 commented 1 year ago

This PR will be merged once the corresponding changes to Mitsuba will be included in the upcoming release.

jmoraispk commented 1 year ago

Thanks 🙏 Could you tell me if there is any arranged timeline for that? Or are there any dependent issues still getting closed?

bathal1 commented 1 year ago

Hi, the next release of Mitsuba 3 should come out in the next weeks, but I can't give you a precise date.

If you really need the add-on to work in Blender 3.6 or downgrading Blender is not a viable option, you could try to use the addon from source. Note that this will require building Mitsuba 3 from source as well, and it's known to be brittle in some cases.

arpit15 commented 1 year ago

@bathal1 Since the new mitsuba is released, I am wondering if there is a timeline for merging this? I am happy to take this initiative if you can't allocate time to this.

arpit15 commented 1 year ago

I tested this branch with mitsuba 3.4.0. @bathal1 It seems to export correct mesh. Is there any other work required for merging this? Is there any other planned work for a new release?