mitsuba-renderer / mitsuba3

Mitsuba 3: A Retargetable Forward and Inverse Renderer
https://www.mitsuba-renderer.org/
Other
2.1k stars 246 forks source link

[Feature] Add setpath for fish shell #1104

Closed LinasBeres closed 5 months ago

LinasBeres commented 8 months ago

Description

This PR adds setpath functionality for the fish shell.

Testing

Local tests on Linux with fish shell.

Checklist

njroussel commented 5 months ago

Hi @LinasBeres

Thanks for the clear PR, but I don't think we'll be keeping it. AFAIK, every other shell has their own completion format/tool, supporting them all would be a mess, and having only fish is a bit awkward. However, feel free to ship this independently, I'm sure some people will appreciate it.