Closed rtabbara closed 3 months ago
Amazing - I was about to re-raise this. I tried the fix and it works for me.
It would be great to also add a unit test.
Good point! I've updated the test_util.py
tests to check whether changes to params actual affect the corresponding plugin variables for both cpp plugins and custom Python plugins.
Looks great!
For custom Python plugins that expose modifiable parameters, updating these values through the use of
mi.traverse
required the use ofassign
to enable updating of the underlying cpp data. i.e. we can propagate the modifications to the actual plugin parameters.For this particular case, we instead rely on nanobind's
nb::inst_replace_copy
function to perform the same functionality.The behaviour updating parameters of cpp plugins remains unchanged.