search

mitsuhiko / insta

A snapshot testing library for rust
https://insta.rs
Apache License 2.0
2.26k stars 102 forks source link

Does anyone use `unseen`? #659

Open max-sixty opened 1 month ago

max-sixty commented 1 month ago

Unseen — Accept all new (previously unseen) — allows automatically accepting snapshots which don't yet exist. I can't see it being that helpful — generally I either want to review any snapshots, or I'm running with --accept and will review in git.

There's some logic from ages ago that looks wrong, https://github.com/mitsuhiko/insta/blob/ce2b3fd10692ecd5ed6d29e0b7a2b6efea327a88/insta/src/runtime.rs#L520-L525, and rather than fix & test it, I might propose deprecating it. To the extent it is indeed wrong, even less likely that people are using the option.

That said, very possibly others find this useful?

xamgore commented 1 month ago

The only way to know for sure, is deprecating the feature and printing this URL into terminals :))

max-sixty commented 1 month ago

Funny you should suggest that: https://github.com/mitsuhiko/insta/pull/668 :)