search

mitsuhiko / minijinja

MiniJinja is a powerful but minimal dependency template engine for Rust compatible with Jinja/Jinja2
https://docs.rs/minijinja/
Apache License 2.0
1.67k stars 101 forks source link

Rust .devcontainer #614

Closed PopFlamingo closed 2 weeks ago

PopFlamingo commented 3 weeks ago

Currently, if you use GitHub Codespaces or Visual Studio Code Dev Containers you need to manually define a .devcontainer directory to create an environment with all the necessary Rust build tools since MiniJinja doesn't define a default one. This can be a slightly cumbersome IMO especially in the case of codespaces as you must first wait for the codespace to start, manually add the files, and then rebuild the container. Having a project defined one also has the advantage of providing a reproducible environment for all contributors as well as being useful to have with features like Copilot Workspace that I suppose also leverages any existing .devcontainer to let you run commands without even needing to open a full codespace instance.

Would it make sense to add one to the repository?

mitsuhiko commented 2 weeks ago

As I'm not using codespaces I'm not familiar with that. However it does sound not particularly maintenance heavy so I would be okay with accepting a PR.

PopFlamingo commented 2 weeks ago

@mitsuhiko Yes this is a very simple configuration and easy to update as VS Code even suggests presets, I added a new PR for it.