search

mitsuhiko / pipsi

pip script installer
Other
2k stars 133 forks source link

Make pipsi a package and make the inline scripts into files #110

Closed pfmoore closed 6 years ago

pfmoore commented 6 years ago

I'm not sure if the test failures here are problems with the PR. Some point to code I added, but others seem to be the "special characters" errors that appear to be hitting all PRs at the moment.

pfmoore commented 6 years ago

Rebased to pick up the test fixes in master

pfmoore commented 6 years ago

OK, looks like there are actual problems I need to fix...

pfmoore commented 6 years ago

Tests fixed, although the final fix just disables one of the "simple install" tests that uses pipsi as a package to install in a way that clashes with having a local directory called pipsi. I'm not particularly happy with doing that, but I can't see a better fix without some more significant surgery on how the test suite works (which I don't have the time to do right now).

RonnyPfannschmidt commented 6 years ago

lets make an issue to track that

pfmoore commented 6 years ago

115 created for this.

RonnyPfannschmidt commented 6 years ago

nicely done, thanks