Improve error handling for local installs

mitsuhiko / pipsi

pip script installer

Other

2k stars 133 forks source link

Improve error handling for local installs #114

Closed jitakirin closed 6 years ago

jitakirin commented 7 years ago

Distinguish between non-packages and invalid setup.py.

Slight refactor of statusoutput necessary to get access to error output from subprocess that runs setup.py.

Close #101

jitakirin commented 7 years ago

Test run failed on Python 3.6 with ConnectionResetError: [Errno 104] Connection reset by peer while downloading virtualenv. Probably just needs to be re-tried, but I can't trigger it myself.

RonnyPfannschmidt commented 7 years ago

seems there is an actual error/behaviour difference

jitakirin commented 6 years ago

got it, forgot you still need to strip the output on 3.6, I'll get that sorted. Just need to setup my environment for tox tests on 3.6.

jitakirin commented 6 years ago

Rebased on master and fixed the remaining issue now. Let me know if that looks all right.