Closed reorx closed 6 years ago
i just resolved the conflicts using the GH UI
Add another two commits to solve the ci tests.
Regarding Pipfile and Pipfile.lock
1.) Under what circumstances would these be used? If the answer is unclear, maybe it should not be part of pipsi. If the answer is clear, can it be added to documentation somewhere? 2.) Who is responsible for updating the .lock file, and when should it be done?
@cs01 thanks for the note
@reorx please remove those 2 from the project
@cs01 actually they are not part of the pipsi package, that's why they are not included in MANIFEST.in
file. It's intended to be used for developing purpose, by running pipenv shell
you can quickly make a virtual environment with dependencies (specified in Pipfile
) installed.
For question 2, Pipfile.lock
is only updated when pipenv update/lock
is called, or dependencies are modified by pipenv install/uninstall
. Whoever wants to change developing tools (tox, pytest etc), or change the real dependencies of pipsi itself, is responsible for updating the lock file (or even Pipfile). This should be done by the time the changes happen.
It's indeed a kind of personal choice, so remove them is OK, maybe better for sticking out the main purpose of this PR.
will merge after green
@RonnyPfannschmidt great, is the current status considered green now?
thanks for the ping,i got sidetracked
Would it be possible to cut a new release with this fix? It would be nice not to have to install from master.
Allow passing python version number for
install --python
e.g.
pipsi install --python 2
, this will find thepython2
executable in$PATH
, and use it to create virtualenv for installing package. This concept is borrowed frompipenv
which has the similar usage likepipenv --python 2
, makes it easier to specify python interpreter, because getting the full path is always a pain.Add
PIPSY_PYTHON
as env var binding for--python
, makes it possible to set the default python interpreter from shell rc file.Use
venv
if python interpreter is python 3.setup.py
also determinesinstall_requires
by python version, andvirtualenv
will only be required for python 2. Thoughvirtualenv
is OK, it's quite clear thatvenv
is the more official and standard way for python 3. Besides, it's good to see a dependency could be removed, glory to Python 3 :DSome other subtle changes including:
tox.ini
:py35
->py36
Pipfile
andPipfile.lock
Could be removed if you think it's not necessary for the project.