search

mitsuhiko / platter

A useful helper for wheel deployments.
Other
335 stars 52 forks source link

Python 3 support #21

Open kottenator opened 9 years ago

kottenator commented 9 years ago

Is it in the nearest plans? Currently there are errors when I try to launch platter build with Python 3.4

jacobsvante commented 9 years ago

I didn't get any errors with Python 3.4 and OS X Yosemite.

jacobsvante commented 9 years ago

My bad @kottenator, The installed command was using python2... Hope my PR makes it up to you :blush:

kottenator commented 9 years ago

No worries. And thanks, I'll try your changes

kottenator commented 9 years ago

@jmagnusson - I've checked your PR, it works great, thanks! However, is @mitsuhiko going to merge it?

jacobsvante commented 9 years ago

One can only hope! He rarely answers to issues / PRs.

mitsuhiko commented 8 years ago

May I ask why this is so important? Surely you have a Python 2 interpreter running on the system where you run platter. Or is this somehow blocking deployment of Python 3 applications in general?

mitsuhiko commented 8 years ago

I'm asking this because I can't imagine that the patch in #27 actually works correctly with packages that use unicode, at least it's going to break this on Python 2. As such I have no intentions of pulling this directly, this would have to be ported in a cleaner form.

SEJeff commented 8 years ago

For one of our projects, we are trying to move to py3k everywhere. Some of the smaller footprint devices won't have py2 on them by default.

Distributions like Arch don't install python 2 by default either.

This is more of a "would be really nice to have" than a hard requirements as we can obviously hack around it.

mitsuhiko commented 8 years ago

Basically if people want Python 3 support then the patches need to not degrade Python 2. Then I'm happy to pull them in. But this also needs continued support. I cannot support things I do not use myself except for projects I really care about. Flask, Click etc. are ones where I'm willing to take Python 3 into account. But I really cannot do it for everything.

ydaniv commented 8 years ago

+1 for py3 support. Will be happy to contribute as necessary

mitsuhiko commented 8 years ago

Feel free to send a pull request :) Just because we're so light on tests here make sure there are no regressions for Python 2 users.