mitsuhiko / similar

A high level diffing library for rust based on diffs
https://insta.rs/similar
Apache License 2.0
974 stars 32 forks source link

`get_close_matches` type incosistency #28

Closed daggy1234 closed 3 years ago

daggy1234 commented 3 years ago

The get_close_matches expects a slice of the type &[&std::string::String], however I have no idea on how one could construct this type. Therefore would a move to the modern &[&str] or even just a &[String] be possible?

mitsuhiko commented 3 years ago

get_close_matches does not expect a &[&String], it works with any DiffableStr. I think this might be a mistake in using it on your part. Maybe you can reopen this issue with a repro case.