search

mitsuhiko / similar

A high level diffing library for rust based on diffs
https://insta.rs/similar
Apache License 2.0
949 stars 31 forks source link

Remove unecessary Ord bound #53

Closed elegaanz closed 10 months ago

elegaanz commented 10 months ago

Hello, I noticed that this bound is not actually required anywhere, and it makes it harder to diff custom types. Please tell me if I'm missing something and that it can't be removed.

mitsuhiko commented 10 months ago

This is intentional, see https://github.com/mitsuhiko/similar/issues/50

I want to make it possible to leverage Ord in the future without breaking the API.

elegaanz commented 10 months ago

Ok, sorry for the noise.