search

mitsuhiko / vim-python-combined

Fork of the python.vim by Dmitry Vasiliev and Neil Schemenauer for 2.x and 3.x.
Other
78 stars 4 forks source link

Use improved syntax file from https://github.com/vim-python/python-syntax #4

Open sloria opened 8 years ago

sloria commented 8 years ago

This copies the syntax file from vim-python/python-syntax, which improves syntax highlighting.

closes #3

lithammer commented 7 years ago

Better yet, use https://github.com/vim-python/python-syntax

sloria commented 7 years ago

Thanks for the tip, @renstrom . It appears that vim-python/python-syntax is the most actively-maintained fork ATM. I've updated this PR to use that instead.

@mitsuhiko Please let me know if there are any blockers to getting this merged.

mitsuhiko commented 7 years ago

Doesn't that defeat the purpose of the repo here? The entire point is that you don't have to set the version of the language.

sloria commented 7 years ago

I don't think it defeats the purpose. The syntax file from vim-python/python-syntax is the best I've seen, and even though you can explicitly specify a Python version, it works out-of-the-box for both versions (I'm currently using it in both Py2 and Py3 codebases).

The value of this repo is that it combines syntax highlighting and pep8 indentation, and consequently is easily integrated by vim-polyglot. If this is merged, I would be able to remove my special-casing for Python (see https://github.com/sloria/dotfiles/blob/9b34d1a4ec4ad4942419b7e93ac60027159240ec/roles/vim/files/vimrc#L147-L154).