search

mittagessen / kraken

OCR engine for all the languages
http://kraken.re
Apache License 2.0
751 stars 131 forks source link

Enhancement/add resize and fix a regression for union #488

Closed PonteIneptique closed 1 year ago

PonteIneptique commented 1 year ago

This fixes #478 and #487.

I discovered a potential regression where the train_codec was not used to resize the output layer. This was causing #487

I added some deprecation regarding #478.

Test and docs are updated

PonteIneptique commented 1 year ago

Here is the potential bug / regression found :

https://github.com/mittagessen/kraken/pull/488/files#diff-974b9dde6ef2001d713a0eaaeb9bb2bd5f0f9c67e10eb1fb6d3aa1ccebee9701R519-R520

mittagessen commented 1 year ago

Yes, it's indeed a regression in the adaptation code.

PonteIneptique commented 1 year ago

There is a doubt in the test I "fixed" with my latest commit, see https://github.com/mittagessen/kraken/issues/487

I think it would be worth checking that I did not fix a test which should not have been fixed... (which has nothing to do with the regression ^^)

mittagessen commented 1 year ago

Could you rebase your branch on main? I can't pull the branch fast-forwardly to test your changes because it branched off from some earlier commit.

PonteIneptique commented 1 year ago

Should be good.