search

mittagessen / kraken

OCR engine for all the languages
http://kraken.re
Apache License 2.0
673 stars 125 forks source link

Bug fixed: adjusted the hyperparameters batch_size check for logging to TensorBoard. #598

Closed Arch-W closed 2 months ago

Arch-W commented 2 months ago

Hello, I'm new to contributing to open-source projects, but I believe I've identified a minor bug in the logging process.

The bug occurs in the validation_step function due to self.hparams.batch_size. Here is my proposed solution: simply change self.hparams.batch_size to self.hparams.hyper_params["batch_size"]. I'm not familiar with the entire codebase, but this resolved my issue.

mittagessen commented 2 months ago

Ah yes, that's a bug. Thanks for the PR.