search

mittal-parth / personal-portfolio

The only developer portfolio template you'll ever need with modern UI/UX.
https://parthmittal.netlify.app/
68 stars 39 forks source link

footer padding fixed #24 #25

Closed Ahnaf-codes closed 1 year ago

Ahnaf-codes commented 1 year ago

Added 1.5 rem padding to left of footer

netlify[bot] commented 1 year ago

Deploy Preview for parthmittal ready!

Name Link
Latest commit aa74dbdd10b20d123cfd0754ba07e0f00aeed820
Latest deploy log https://app.netlify.com/sites/parthmittal/deploys/633a785d15d4680008867db4
Deploy Preview https://deploy-preview-25--parthmittal.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Ahnaf-codes commented 1 year ago

@mittal-parth its done

Ahnaf-codes commented 1 year ago

@mittal-parth done

mittal-parth commented 1 year ago

@Ahnaf-codes great, the padding looks right now. Please indent using 4 spaces and not 8, and I can merge it. Also, even though I'll squash the commits, its a good practice to use more descriptive commit messages😀

Ahnaf-codes commented 1 year ago

Its done. @mittal-parth

mittal-parth commented 1 year ago

@Ahnaf-codes ah I am so sorry, it had to be 2 spaces and not 4 😞. So sorry for the inconvenience

Ahnaf-codes commented 1 year ago

@mittal-parth its done

mittal-parth commented 1 year ago

@Ahnaf-codes Merged! I had meant using 2 spaces for the entire file and not just that changed line. Rest I rebased it off main, resolved merge conflicts and merged.