search

mittinatten / freesasa

C-library for calculating Solvent Accessible Surface Areas
http://freesasa.github.io/
MIT License
103 stars 37 forks source link

Addressed AltLoc CIF bug in structure_from_doc #52

Closed danny305 closed 3 years ago

danny305 commented 3 years ago

Also refactored a little bit of your cif.cc file to use unique_ptrs.

danny305 commented 3 years ago

I have rebased my pr branch to remove all the cmake stuff.

I pulled in the changes you made for autotools to work on my computer. I updated the c++ minimum standard to c++14 so it would successfully compile.

mittinatten commented 3 years ago

The git -> https submodule change wasn't here, but it turns out is needed in travis for CI as well. So I added it myself. (not sure if this link is publicly available: https://travis-ci.org/github/mittinatten/freesasa/jobs/759850250)

danny305 commented 3 years ago

Good catch!