Options.Namespace takes priority over ChartSpec.Namespace

elonsalfati commented 2 years ago

My use case: I have initialized a helm client, and I'm iterating through multiple charts and installing them one by one. Different charts go to different namespaces.

I've initialized the helm client like this:

        opt := &helmclient.KubeConfClientOptions{
            Options: &helmclient.Options{
                Namespace:        "default",
                RepositoryCache:  "/tmp/.helmcache",
                RepositoryConfig: "/tmp/.helmrepo",
                Debug:            true,
                Linting:          true,
                DebugLog: func(format string, v ...interface{}) {
                    fmt.Printf(format, v...)
                    fmt.Printf("\n")
                },
            },
            KubeContext: kubecontext,
            KubeConfig: kubeconfig,
        }

        // initialize helm client with the correct kube context
        helmClient, err := helmclient.NewClientFromKubeConf(opt, helmclient.Burst(100), helmclient.Timeout(time.Duration(time.Minute*15)))
        if err != nil {
            return err
        }

and my ChartSpec looks like:

    chartSpec := helmclient.ChartSpec{
        ReleaseName: m.Name,
        ChartName: m.HelmPackage,
        Version: "0.1.0",
        ValuesYaml: string(buf),
        DryRun: m.dryRun,
        Wait: false,
        Timeout: time.Duration(time.Minute*15),
        Namespace: m.Namespace,
        CreateNamespace: true
    }

I've set the ChartSpec.Namespace = "nopeus" and ChartSpec.CreateNamespace = true accordingly and ran InstallOrUpgradeChart with the chart.

Yet when I run this, the charts are deployed to the default namespace instead of the intended nopeus namespace. Which isn't a behavior I would expect.

I would love your help on this. Am I missing something? Is it a bug? Should I just create a new client every time (sounds weird)?