superficial controller improvements - Githubissues

mittwald / harbor-operator

A Kubernetes operator for managing goharbor instances

Apache License 2.0

20 stars 4 forks source link

superficial controller improvements #35

Closed elenz97 closed 4 years ago

elenz97 commented 4 years ago

Drop unused arguments
Fix upper/lower-casing in comments, add comment dots
Compare error types via 'errors.Is()', not 'if err == type [...]'
In 'GenerateHashFromInterfaces()', pre-allocate the 'hashSrc' slice
Make the TestCreateSpecHash() testcase check that hashes are not varying