mittwald / kubernetes-secret-generator

Kubernetes controller for automatically generating and updating secrets
Apache License 2.0
330 stars 57 forks source link

add ssh secrets #19

Closed hensur closed 4 years ago

hensur commented 4 years ago

rebased on #18 / master

This change adds the capability of generating ssh secrets to the secret operator.

While implementing this, I also moved the password generation to a different file, which allows for further extension of the operator with additional secret generators.

I also moved the test cases to generator specific files.

Furthermore, I noticed, that golangs string formatter on the time type is quite verbose. The generated-at annotation now contains a RFC3339 compliant time string.

Since the string generator now also respects the length annotation: fixes #16

hensur commented 4 years ago

@martin-helmich I've rebased this on the current master. This change is finally ready for review :) The CI still fails because Actions triggered by PRs from a fork of the repository don't have access to secret values. I'll disable the code-climate reporting for PRs in another PR.