mittwald / kubernetes-secret-generator

Kubernetes controller for automatically generating and updating secrets
Apache License 2.0
330 stars 57 forks source link

Add ability to generate secrets from CRs #35

Closed YannikBramkamp closed 3 years ago

YannikBramkamp commented 3 years ago

Closes #34

YannikBramkamp commented 3 years ago

Notes:

mittwald-machine commented 3 years ago

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

martin-helmich commented 3 years ago

@YannikBramkamp Thanks for all your work on this! :+1: I'll happily review this, but since this is a big one, it might take a few days until I get to it... ⏳

martin-helmich commented 3 years ago

I'll happily review this, but since this is a big one, it might take a few days until I get to it... ⏳

@YannikBramkamp Finally got around to leaving a few notes on this -- sorry it took so long. 🙄🙏

mittwald-machine commented 3 years ago

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

YannikBramkamp commented 3 years ago

@martin-helmich This should be ready now, I hope I didn't forget anything, as there was quite a bit of time between when I started to implement the requested changes and when I finished,

mittwald-machine commented 3 years ago

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

martin-helmich commented 3 years ago

@YannikBramkamp Sorry for letting this stew for so long... We really need to get @mittwald-machine under control. 😅

YannikBramkamp commented 3 years ago

@martin-helmich I've iImplemented the changes.