search

mittwald / kubernetes-secret-generator

Kubernetes controller for automatically generating and updating secrets
Apache License 2.0
330 stars 57 forks source link

Make cluster role optional #38

Closed day1118 closed 3 years ago

day1118 commented 3 years ago

Resolves #37

day1118 commented 3 years ago

That makes sense. Are you happy with the code changes? If so I'll draft something for the readme.

Edit: Updated docs - let me know if you would like further changes @martin-helmich

day1118 commented 3 years ago

Hi @martin-helmich Anything further that you require so that this can be merged? Thanks

day1118 commented 3 years ago

Can you please provide any feedback/review @martin-helmich Thanks

day1118 commented 3 years ago

I marked a few small nitpicks, apart from that this looks good to me

Thanks @YannikBramkamp - changes have been accepted

martin-helmich commented 3 years ago

@YannikBramkamp Looks like the changes you've requested have been implemented. Do you want to have a last look? Otherwise, I'll probably just go ahead and merge this shortly.

YannikBramkamp commented 3 years ago

@martin-helmich looks good to me, too