search

mittwald / kubernetes-secret-generator

Kubernetes controller for automatically generating and updating secrets
Apache License 2.0
330 stars 57 forks source link

Add correct permissions for monitoring service and make its creation optional #42

Closed YannikBramkamp closed 3 years ago

YannikBramkamp commented 3 years ago

Closes #41

mittwald-machine commented 3 years ago

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

martin-helmich commented 3 years ago

@YannikBramkamp This one is still marked as "Draft" and is getting stale by now. Is this ready for review, or does it still need some ❤️?

YannikBramkamp commented 3 years ago

@YannikBramkamp This one is still marked as "Draft" and is getting stale by now. Is this ready for review, or does it still need some heart?

@martin-helmich I figured I'd wait for #38 to be merged, since I'll preobably have to make some changes to this pr.

mittwald-machine commented 3 years ago

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

YannikBramkamp commented 3 years ago

This should be ready now @martin-helmich