Backwards compatibility broken because of CRDs

mittwald / kubernetes-secret-generator

Kubernetes controller for automatically generating and updating secrets

Apache License 2.0

342 stars 60 forks source link

Backwards compatibility broken because of CRDs #71

Closed ptcar2009 closed 2 years ago

ptcar2009 commented 2 years ago

Describe the bug Previously, the deployment would work with just tag based secret injection, but after the CRDs were introduced, it's impossible to use it without CRDs installed.

To Reproduce Deploy the helm-chart with the flag skip-crds and try to inject a secret. Expected behavior The pod would detect or at least there would be a configuration which would make the deployment work.

Environment:

Kubernetes version: v1.21.5
kubernetes-secret-generator version: >=v3.3.3

day1118 commented 2 years ago

Hi @martin-helmich We have raised #70 to address this issue. Can you please review & merge it? Thanks

martin-helmich commented 2 years ago

Hi @martin-helmich

We have raised #70 to address this issue. Can you please review & merge it?

Thanks

Apologies for the late response. I'll take a look shortly. 👀