search

mittwald / kubernetes-secret-generator

Kubernetes controller for automatically generating and updating secrets
Apache License 2.0
342 stars 60 forks source link

ARM64 Image #80

Open neilclark-bgn opened 2 years ago

neilclark-bgn commented 2 years ago

Currently we run a mixture of AMD64 and ARM64 nodes in our clusters, and are slowly moving more workloads to AWS ARM based Graviton nodes due to to the lower running costs.

The secret generator is incredibly useful to us and we run it in all of our clusters. Please would you consider building a multi-arch image including support for ARM64. This would aid us in our plan to run ARM64 only clusters in future.

mittwald-machine commented 2 years ago

There has not been any activity to this issue in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

martin-helmich commented 2 years ago

Sorry, this should not have gotten stale. This is a valid request, but I cannot make any promises as to when we'd be getting around to it. In the meantime, PRs are welcome. 🙂

devfaz commented 1 year ago

Would also be interested in having this feature :+1:

anon-software commented 1 year ago

My issue for the same feature https://github.com/mittwald/kubernetes-secret-generator/issues/77 also turned stale and was automatically closed. I was able to build one myself from the source code at the time. If you are interested, you can get the image from anonsoftware28/kubernetes-secret-generator repository in docker.io. The link to it is https://hub.docker.com/r/anonsoftware28/kubernetes-secret-generator.

And before you ask, it is not nearly ready for a proper pull request. Similarly to the official code, it only generates ARM64 image, but ideally we want them all. I remember jumping through the hoops to upload that image, it was not nearly as automated as it should be.

If it helps anything, I can run a diff on my local repository. I do not guarantee it is in the state it was when I generated the image, but it may serve as a starting point for somebody. I do not see myself getting into it any time soon.

devfaz commented 1 year ago

@anon-software would be nice if you could provide some hints/diff how you build the code for arm, may help others to continue here.

steveannett commented 1 year ago

@anon-software has a fork, the difference is here. This issue would have been great candidate for Hacktoberfest, but hopefully someone will be able to offer a solution before the next one.

ab77 commented 1 year ago

I feel like the ideal way to do this, is to update the existing workflow to a matrix build, broadly following this approach.

For my (immediate and selfish) purposes however, I shimmed an extra build job in front of our CI script (which was already 80%+ there) to build the operator binaries and then inject them into the CI docker-bake workflow. Images are in the public ghcr.io registry. Please feel free to consume:

docker pull ghcr.io/belodetek/kubernetes-secret-generator:v0.0.3

To update, open a PR with a submodule digest bump.

Fenrur commented 10 months ago

It bothers me to have to manage a registry with the Arm image