mittwald / kubernetes-secret-generator

Kubernetes controller for automatically generating and updating secrets

Apache License 2.0

329 stars 56 forks source link

Allow Customization of ssh-privatekey and ssh-publickey for SSHKeyPair #92

Open jkupferer opened 8 months ago

jkupferer commented 8 months ago

Is your feature request related to a problem? Please describe.

For compatibility with using deploy keys with ArgoCD it is necessary to be able to generate SSH keypair secrets with data sshPrivateKey rather than the default ssh-privatekey.

Other use cases may also require the SSH public and private keys to use custom data names.

Describe the solution you'd like

Perhaps add spec.sshPrivateKeyDataName and spec.sshPublicKeyDataName to SSHKeyPair custom resource to allow overriding the defaults?

Describe alternatives you've considered

I've been unable to come up with a reasonable alternative.

Additional context

n/a

jkupferer commented 8 months ago

91 addresses similar needs. Perhaps this feature request should be folded into that one?

martin-helmich commented 8 months ago

Perhaps add spec.sshPrivateKeyDataName and spec.sshPublicKeyDataName to SSHKeyPair custom resource to allow overriding the defaults?

That sounds reasonable! Currently, our capacities to work on this project are limited, so PRs are always welcome.

mrchypark commented 7 months ago

@jkupferer I am currently attempting to work on https://github.com/mittwald/kubernetes-secret-generator/issues/91. I would like to address this issue together. Can we discuss the design aspect in https://github.com/mittwald/kubernetes-secret-generator/issues/91?

jkupferer commented 2 weeks ago

@mrchypark Sorry for having missed your comment for so long. Is this something you are still looking at?

mrchypark commented 2 weeks ago

@jkupferer No. I was also busy with other things, so I couldn't keep up with it even though it was necessary. We can restart the conversation if needed.