search

mittwald / typo3-web2pdf

A TYPO3 extension for rendering content as PDF
GNU General Public License v2.0
18 stars 20 forks source link

Difference in Commit tagged with '1.1.6' composer.json and ext_emconf.php #111

Closed fabianbruggmann closed 4 years ago

fabianbruggmann commented 4 years ago

In Version "1.1.6" there is a difference in the TYPO3 dependency.

ext_emconf.php

https://github.com/mittwald/typo3-web2pdf/blob/9f5642c7199663101c688edf4eaf4e34f49829a1/ext_emconf.php#L40

composer.json

https://github.com/mittwald/typo3-web2pdf/blob/9f5642c7199663101c688edf4eaf4e34f49829a1/composer.json#L11

Since versions "1.1.4" and "1.2.1" have TYPO3 "7.6.x" as a dependency I believe this to be an error, which could be detrimental when changing from non-composer-mode to composer-mode on old installations, when preparing an upgrade.

pstranghoener commented 4 years ago

Thats hard to fix in old versions. In the new version its correct, so we close that issue.