mittwald / typo3-web2pdf

A TYPO3 extension for rendering content as PDF
GNU General Public License v2.0
18 stars 20 forks source link

Content-Disposition inline or attachment #15

Closed klodeckl closed 9 years ago

klodeckl commented 9 years ago

Sometimes the PDF should be displayed inline in the browser window instead of making a download. For that Classes/View/PdfView.php line 104 should be changed from header('Content-Disposition: attachment; filename="' . $this->fileNameUtility->convert($pageTitle) . '.pdf' . '"'); to header('Content-Disposition: inline; filename="' . $this->fileNameUtility->convert($pageTitle) . '.pdf' . '"‘); stehen.

A typoscript option for that would be great!

martin-helmich commented 9 years ago

This should be a TypoScript option, defaulting to Content-Disposition: attachment; anything else would break backwards compatibility.

christian-hellmuth commented 9 years ago

+1 for that TypoScript option as it will also make it easier to debug the generated PDF output when not set to attachment.

kpurrmann commented 9 years ago

38