search

mitxpro-dev / learnjs

Learn JS
https://mitxpro-dev.github.io/learnjs/
MIT License
1 stars 2 forks source link

Bug: Homepage routing fix #11

Closed HudsonGraeme closed 1 year ago

HudsonGraeme commented 1 year ago

resolves #10

# Description Issue: #10 - [x] Added `trailingSlash: true` to `next.config.js` to fix home routing issues # Screenshots
Click here for screenshots https://github.com/mitxpro-dev/learnjs/assets/25019680/cce1274b-d9cb-459e-a53a-4bad1adb8def
# Notes Failed to reproduce this issue locally. In the browser, this link renders correctly with the `href` pointing to `/`. It is suspected that when deployed to GH actions, the base URL is incorrect. Was unable to determine root cause of the issue but did find a viable solution by adding trailing slashes to paths
HudsonGraeme commented 1 year ago

Thanks @codeTrackLift.

Forked the repo to try this out on GH pages without messing up the group repository here. Findings so far are essentially the last 4 characters are being chopped off the base path regardless of whether I hardcode basepath, or change the repo name... Ex https://hudsongraeme.github.io/mit-project/challenges.

This PR doesn't fix the problem unfortunately, but I'll update it with the actual solution as soon as I'm able to identify it over on my forked version

HudsonGraeme commented 1 year ago

Lol during the time I'm trying to troubleshoot

image
HudsonGraeme commented 1 year ago

@codeTrackLift Update label to reflect mergable state!

Please see deployed fix over on my GH pages: https://hudsongraeme.github.io/learnjs/

codeTrackLift commented 1 year ago

@codeTrackLift Update label to reflect mergable state!

Please see deployed fix over on my GH pages: https://hudsongraeme.github.io/learnjs/

Awesome job @HudsonGraeme! 🔥