Fix: Hero image resolution

codeTrackLift commented 1 year ago

The hero image looks pixelated at desktop resolution, see screenshot below.
Find and propose a solution.
Dev notes:
- It looks like the hero image is from the Unsplash api
- Image width looks to be accessible as a query param, 1440px might be nice?
- Link to Unsplash documentation on query params
- Bonus: extract the url as a constant that is declared below the imports

Click here to see screenshot

![Screenshot 2023-07-04 at 9 54 07 AM](https://github.com/mitxpro-dev/learnjs/assets/96446064/dd480e20-6485-410c-aacb-222b30a1888f)

codeTrackLift commented 1 year ago

CC: @drewpate if you have time, this might be a nice follow-up to your PR# 13, but all good either way.

drewpate commented 1 year ago

@codeTrackLift absolutely! I'll see what I can do after the holiday.

HudsonGraeme commented 1 year ago

@drewpate Thanks!!

drewpate commented 1 year ago

@codeTrackLift @HudsonGraeme I made some changes based on the previous input. Image resolution was looking better on my end. I think there's a merge that was not supposed to happen. I'm still working from my own fork for now.

codeTrackLift commented 1 year ago

Sorry @drewpate, that was my bad. I merged PR #13 for you.

mitxpro-dev / learnjs

Fix: Hero image resolution #22