mitxpro-dev / learnjs

Learn JS
https://mitxpro-dev.github.io/learnjs/
MIT License
1 stars 2 forks source link

Blank Page #37

Closed drewpate closed 1 year ago

drewpate commented 1 year ago

The GitHub Page is coming up blank. When running locally it. Looks like there is an issue with the base url. Take a look at the vite.config.ts file and the base Route in App.tsx

HudsonGraeme commented 1 year ago

Shoot that’s my fault, thanks for making this @drewpate

drewpate commented 1 year ago

@HudsonGraeme I created a pull request with my fix. Hopefully this is all it needs, or there might be something else required.

codeTrackLift commented 1 year ago

Hey @HudsonGraeme @drewpate,

Did a little bit of troubleshooting on this issue and found the following:

HudsonGraeme commented 1 year ago

Thanks for the troubleshooting @codeTrackLift, @drewpate let me know about a SO thread on the topic and there was a note in there about basename in <BrowserRouter/>

I suspect because we're using react-router-dom, the router is not basing it's main route off of /learnjs but instead / and as a result doesn't serve a page at any of the known routes. I made a change to my fork here and the site is deployed and working as expected... I'll open a PR here for the same change and start praying this is the fix :joy:

HudsonGraeme commented 1 year ago

Success! https://mitxpro-dev.github.io/learnjs/

codeTrackLift commented 1 year ago

@HudsonGraeme awesome! 🤩

drewpate commented 1 year ago

🤩 excellent work guys! @HudsonGraeme @codeTrackLift