search

mitxpro-dev / learnjs

Learn JS
https://mitxpro-dev.github.io/learnjs/
MIT License
1 stars 2 forks source link

fixes issue with vite.config.ts base #38

Closed drewpate closed 1 year ago

drewpate commented 1 year ago
# Description Issue: #37 - [ ] Change 1 Updated the base from '/learnjs/' to just '/' to match the base URL in App.tsx # Screenshots ![Screen Shot 2023-07-10 at 8 56 41 PM](https://github.com/mitxpro-dev/learnjs/assets/82974106/602e02b2-fcc4-4c56-9e1f-a14bd4be4cec) ![Screen Shot 2023-07-10 at 8 56 51 PM](https://github.com/mitxpro-dev/learnjs/assets/82974106/a6756fa7-5171-48c0-93a1-e01041222685) # Notes Not sure if there's a way to get the baseurl to work a different way but this fixed the issue locally.
drewpate commented 1 year ago

@HudsonGraeme @codeTrackLift I'm not sure why there were so many file changes. It could be that prettier or VSCode messed with them.

codeTrackLift commented 1 year ago

@codeTrackLift I'm not sure why there were so many file changes.

@drewpate let me know if you want any help with this. I should have some time this sat morning.

drewpate commented 1 year ago

@codeTrackLift I'm not sure why there were so many file changes.

@drewpate let me know if you want any help with this. I should have some time this sat morning.

@codeTrackLift I can take care of adding the aforementioned file to the .gitignore and we will go from there!

drewpate commented 1 year ago

Looks like there's a .next folder that made its way into this PR? Should this be in the .gitignore or removed from the build since we are pivoting to Vite?

@codeTrackLift I've added *.next into the .gitignore file. Curious to see if we will have the blank page fixed after we merge.

codeTrackLift commented 1 year ago

Thanks @drewpate. Looks like the .next file is still part of the PR and the commit appears to add 18k+ lines...

Screenshot 2023-07-13 at 8 14 44 PM
drewpate commented 1 year ago

Thanks @drewpate. Looks like the .next file is still part of the PR and the commit appears to add 18k+ lines...

Screenshot 2023-07-13 at 8 14 44 PM

@codeTrackLift I'm seeing this now too. At the point I'm pretty stuck, not sure how to move forward.

codeTrackLift commented 1 year ago

No worries, an easy solution is to just close this branch and open a new one with just the intended change. I'd make sure your local environment matches what you intend to commit to the repo. Maybe a fresh clone wouldn't hurt, especially after the pivot?