mity / md4c

C Markdown parser. Fast. SAX-like interface. Compliant to CommonMark specification.
MIT License
756 stars 138 forks source link

Add .gitignore #119

Closed cxw42 closed 4 years ago

cxw42 commented 4 years ago

Thank you for this project, which I have just started using and which seems very useful! I noticed that compiling md4c dirties the Git repo, so I added a .gitignore file. I submit it here in hopes it will be helpful to you or others. Thanks for considering this PR!

Note on sources: the .gitignore is mostly the GitHub C gitignore. I have added some lines for autotools, since I am using autotools to build a project that uses md4c as a submodule.

Notes on contents: Makefile is ignored. I think this is OK since you are using CMake instead of make, but I am happy to change it if you prefer. I can also add /build/ if you want that, since that's the CMake build dir for Travis.

Please let me know if you have any questions or comments. Thank you!

codecov[bot] commented 4 years ago

Codecov Report

Merging #119 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   94.31%   94.31%           
=======================================
  Files           3        3           
  Lines        3060     3060           
=======================================
  Hits         2886     2886           
  Misses        174      174           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dec6e22...3ec2b74. Read the comment docs.

mity commented 4 years ago

Notes on contents: Makefile is ignored. I think this is OK since you are using CMake instead of make, but I am happy to change it if you prefer.

That's ok, as Makefile is generated (if people use the CMake's make generator).

I can also add /build/ if you want that, since that's the CMake build dir for Travis.

I don't think Travis cares so I'm indifferent. It can always be added later when a need arises.

mity commented 4 years ago

Merged. Thanks.

cxw42 commented 4 years ago

Thanks very much for the quick review and approval!