mity / md4c

C Markdown parser. Fast. SAX-like interface. Compliant to CommonMark specification.

MIT License

756 stars 138 forks source link

Added fuzzer for oss-fuzz integration. #151

Closed DavidKorczynski closed 3 years ago

DavidKorczynski commented 3 years ago

Hi Maintainers,

I have worked a bit on setting fuzzing up for md4c by way of OSS-Fuzz. https://github.com/google/oss-fuzz/pull/5242 I have done exactly that, namely created the necessary logic from an OSS-Fuzz perspective to integrate md4c. If you would like to integrate, could you please provide a set of email(s) that will get access to the data produced by OSS-Fuzz, such as bug reports, coverage reports and more stats. The emails should be linked to a Google account in order to view the detailed reports and notice the emails affiliated with the project will be public in the OSS-Fuzz repo, as they will be part of a configuration file.

At the moment I stored the fuzzers (in the PR I linked) in the Google OSS-Fuzz repository, but we can move them up here to make maintenance easier.

I noticed that you had previously asked if MD4C is qualified https://github.com/google/oss-fuzz/issues/2134 and I believe following the QT integration it should be ready now!

codecov[bot] commented 3 years ago

Codecov Report

Merging #151 (5253968) into master (269bbdb) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files           3        3           
  Lines        3068     3068           
=======================================
  Hits         2898     2898           
  Misses        170      170

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 269bbdb...5253968. Read the comment docs.

mity commented 3 years ago

Wonderful. This is great to have.

DavidKorczynski commented 3 years ago

Great stuff! Let me know which email you would like to use for the bug reports!

mity commented 3 years ago

If you would like to integrate, could you please provide a set of email(s) that will get access to the data produced by OSS-Fuzz, such as bug reports, coverage reports and more stats.

I have no dedicated per-project e-mail addresses, so martin.mitas@morous.org would do. (I believe it should not be a problem to change later if needed, right?)

DavidKorczynski commented 3 years ago

Awesome! Yeah, it's no problem at all to change it.

mity commented 3 years ago

(Just FYI, started to receive mail notifications from it (cool), but I cannot get to the detailed reports, I believe due this bug: https://github.com/google/oss-fuzz/issues/4809)

DavidKorczynski commented 3 years ago

Ah - that looks annoying. Am not entirely sure what to do about this, but probably the best is to follow up on the OSS-Fuzz issue.