search

mity / md4c

C Markdown parser. Fast. SAX-like interface. Compliant to CommonMark specification.
MIT License
755 stars 138 forks source link

[WIP] Get rid of ROLLBACK_ALL. #218

Closed mity closed 5 months ago

mity commented 5 months ago

This code is mess, consequences of its use for caller are very hard to grasp correctly, and it also have strange corner cases.

The need to use it more or less always means there's something stinky in the code calling it.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4728cd9) 94.53% compared to head (76a3680) 94.57%.

Files Patch % Lines
src/md4c.c 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #218 +/- ## ========================================== + Coverage 94.53% 94.57% +0.04% ========================================== Files 3 3 Lines 3147 3135 -12 ========================================== - Hits 2975 2965 -10 + Misses 172 170 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mity commented 5 months ago

Won't be merged. Instead we committed d40458b5b5a2d1dec9924aeca74a7d76fe0176c1 into master.