mity / md4c

C Markdown parser. Fast. SAX-like interface. Compliant to CommonMark specification.
MIT License
759 stars 140 forks source link

[WIP] Fixes #62

Closed mity closed 5 years ago

mity commented 5 years ago

Work on fixing few issues:

mity commented 5 years ago

The commit 1599809 caused regression in Example 322. This is a calculated trade-off which should be resolved in the upcoming work.

codecov[bot] commented 5 years ago

Codecov Report

Merging #62 into master will decrease coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage    92.7%   92.61%   -0.09%     
==========================================
  Files           1        1              
  Lines        2577     2573       -4     
==========================================
- Hits         2389     2383       -6     
- Misses        188      190       +2
Impacted Files Coverage Δ
md4c/md4c.c 92.61% <100%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbae179...1599809. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #62 into master will decrease coverage by 0.02%. The diff coverage is 96.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage    92.7%   92.68%   -0.03%     
==========================================
  Files           1        1              
  Lines        2577     2582       +5     
==========================================
+ Hits         2389     2393       +4     
- Misses        188      189       +1
Impacted Files Coverage Δ
md4c/md4c.c 92.68% <96.26%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbae179...8cba18d. Read the comment docs.

mity commented 5 years ago

The commit 9107ffc caused regression in Example 325 and Example 572. This is a calculated trade-off which should be resolved in the upcoming work: We need to move autolink also into md_collect_marks().

mity commented 5 years ago

Aborted. Not done the right way.