mity / md4c

C Markdown parser. Fast. SAX-like interface. Compliant to CommonMark specification.

MIT License

759 stars 140 forks source link

[WIP] Updates for spec 0.29 #67

Closed mity closed 5 years ago

mity commented 5 years ago

Given the recent activity in https://github.com/commonmark/CommonMark, I guess specification 0.29 is quite close. Lets be ready for it.

(Won't be merged into master until the 0.29 specification is finally released.)

codecov[bot] commented 5 years ago

Codecov Report

Merging #67 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files           1        1           
  Lines        2616     2616           
=======================================
  Hits         2429     2429           
  Misses        187      187

Impacted Files	Coverage Δ
md4c/md4c.c	`92.85% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a80e2e1...eb6a221. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #67 into master will increase coverage by 1.22%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   92.85%   94.07%   +1.22%     
==========================================
  Files           1        1              
  Lines        2616     3343     +727     
==========================================
+ Hits         2429     3145     +716     
- Misses        187      198      +11

Impacted Files	Coverage Δ
md4c/md4c.c	`94.07% <100%> (+1.22%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a80e2e1...9885028. Read the comment docs.

mity commented 5 years ago

~~The commit 6e49193 still may need some attention, as we still disagree with the example in the specs, just in a different way. See https://github.com/commonmark/cmark/issues/193#issuecomment-476589873~~

EDIT: Not true. The new specs is clear about this. Fixed our implementation in 94c86fe.

mity commented 5 years ago

As of https://github.com/commonmark/CommonMark/commit/c1e0183685e22282cbf5651970200fe56a712002, this PR should be complete and we pass all the specs tests.