Closed mity closed 4 years ago
Merging #97 into master will decrease coverage by
<.01%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 94.02% 94.01% -0.01%
==========================================
Files 1 1
Lines 2660 2642 -18
==========================================
- Hits 2501 2484 -17
+ Misses 159 158 -1
Impacted Files | Coverage Δ | |
---|---|---|
md4c/md4c.c | 94.01% <100%> (-0.01%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e97d025...29e50cd. Read the comment docs.
md_is_table_row()
did some crazy inline parsing to detect whether the line contains at least one pipe which is not inside a code span or other high-priority inline element.This was very complicated under the hood and to was actually breaking the clean design which separates block analysis parse and inline analysis of each block contents.
We now just use the table underline for determining the block is table and its properties.
This means a paragraph now cannot interrupt a table. This is a change in a behavior but likely acceptable one as it actually brings the behavior closer to behavior of tables in cmark-gfm in this regard.
Last but not least, it seems to prevent adoption of other useful features, for about that, see the discussion in PR #92.