Statamic 5 - Githubissues

mitydigital / statamic-feedamic

An Atom and RSS feed for Statamic 3, 4 and 5

https://docs.mity.com.au/feedamic

8 stars 9 forks source link

Statamic 5 #23

Closed duncanmcclean closed 6 months ago

duncanmcclean commented 7 months ago

This pull request updates the addon to be compatible with Statamic 5.

Apologies for the early PR - I use this addon on my personal site and wanted to have a PR to patch in so I can deploy the alpha. Feel free to ignore until it's properly released 😆

Changes:

Ignored the vendor directory and composer.lock file from version control
Updated the statamic/cms version constraint in composer.json

From what I can tell, everything seems to be working fine with these changes. Although, obviously, you know this addon better than I do so I might have missed something.

martyf commented 7 months ago

5 support has been on my list so you've beaten me to it

Maybe a daft one, but is the version constraint now forcing only 5.0+? Any logic or reasoning behind this?

Side note: I've got a major rewrite in mind including a test suite, and was planning to drop older versions at that point as that will be a major version bump - but it is so simple in the scheme of things that this version should still run with no issues in 3, 4 and 5.

duncanmcclean commented 7 months ago

Maybe a daft one, but is the version constraint now forcing only 5.0+? Any logic or reasoning behind this?

Yes. Generally, I'd only expect addons to support the latest major version of Statamic. That's what I've always done and that's what we do for our first-party addons at Statamic.

It also means you won't have to workaround any potential breaking changes etc and it reduces the surface area for bugs to crop up on.

martyf commented 6 months ago

Bah renaming branches and one too many odd clicks.

Will merge this in, and v3 will be a major rewrite: when that happens I will drop v4 support.