Dates not reporting correctly on some readers

mitydigital / statamic-feedamic

An Atom and RSS feed for Statamic 3, 4 and 5

https://docs.mity.com.au/feedamic

8 stars 9 forks source link

Dates not reporting correctly on some readers #9

Closed spaceageliving closed 2 years ago

spaceageliving commented 2 years ago

Bug description

On some readers (like NetNewsWire on iPad, see photo), dates are not being reported correctly--dates are showing Dec 31, 1969 for all entries. Other readers, like Reedy on MacOS, not a problem.

NetNewsReader:

Reedy:

Steps to reproduce

Open feed in NetNewsWire, Reeder.

Environment and versions

Statamic 3.3.36 Pro
Laravel 8.83.23
PHP 8.1.8
aerni/social-links 2.3.1
mitydigital/feedamic 2.2.0
optimoapps/statamic-bard-text-align 1.0.2
stillat/meerkat 2.6.0

Additional details

No response

spaceageliving commented 2 years ago

Update: I published the views, and updated the date outputs to use ->toRfc2822String(), which formats the year as 4 digits as opposed to 2 digits when using ->toRfc822String(). This seems to fix the problem, continuing to test.

martyf commented 2 years ago

Thanks for creating this issue.

Can you confirm that you're only seeing the issue with the RSS feed, but not with the Atom feed?

spaceageliving commented 2 years ago

Atom feed seems fine without modification on NetNewsReader (iPadOS) and Reeder (MacOS).

Everything looks good for RSS feed using ->toRfc2822String().

martyf commented 2 years ago

Cool bananas - I've release 2.2.1 which addresses this issue.

Thanks for your help with this, and the quality of your issue report: really appreciate it!

spaceageliving commented 2 years ago

Thanks for making this package! Big help...

martyf commented 2 years ago

Woot! Really glad you've found it useful 😁