fix "Array to string conversion" error

mitydigital / statamic-tinymce-cloud

A Statamic fieldtype for TinyMCE using Tiny Cloud for Statamic 3.3+ and Statamic 4.0

https://docs.mity.com.au/tinymce-cloud

MIT License

2 stars 1 forks source link

Closed IVoyt closed 3 weeks ago

IVoyt commented 3 weeks ago

the commit fixes permanent "Array to string conversion" error

martyf commented 3 weeks ago

What steps do I need to follow to replicate the issue this is attempting to fix?

IVoyt commented 3 weeks ago

What steps do I need to follow to replicate the issue this is attempting to fix?

just save any TinyMCE config in Statamic CP. Example config from the documentation should reproduce the error.

The result will be error in ConfigurationDefaults.php

martyf commented 3 weeks ago

Righto this is really interesting... on one Statamic 5 site, I do not get the error: but on another I do.

Your PR fixes one... but for the other no PR is needed. Really odd, so looking in to this now.

martyf commented 3 weeks ago

An update to Statamic's core in 5.7.0 introduced this issue.

I'll merge this PR, and then update it to work with < 5.7 too, and tag it shortly after.

IVoyt commented 3 weeks ago

Ah, sorry, I forgot to note it is Statamic 5.7.x

Thanks!