search

miukimiu / react-kawaii

Cute SVG React Components
https://react-kawaii.vercel.app/
MIT License
2.91k stars 104 forks source link

Makes protype mood oneOf #2

Closed aliciacatalina closed 7 years ago

aliciacatalina commented 7 years ago

Uses Reacts oneOf to the mood protype in both components. https://facebook.github.io/react/docs/typechecking-with-proptypes.html Thought it would be nice to have it explicitly in the Proptypes.

Let me know what you think :)

miukimiu commented 7 years ago

Hi @aliciacatalina, You're right. Much better the code. I'm going to merge.

Thanks! 😃