`[id]` attributes on the page are not unique

miukimiu / react-kawaii

Cute SVG React Components

https://react-kawaii.vercel.app/

MIT License

2.91k stars 104 forks source link

`[id]` attributes on the page are not unique #83

Closed sueannioanis closed 4 years ago

sueannioanis commented 4 years ago

Accessibility fixes for assistive technologies and to improve the lighthouse score. 😄

[id] attributes on the page are not unique.

Each value of an id attribute must be unique to prevent other instances from being overlooked by assistive technologies.

There are still some more left to cover. Reference rule here.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/miukimiu/react-kawaii/nu7bqltph ✅ Preview: https://react-kawaii.now.sh

sueannioanis commented 4 years ago

@miukimiu Hey! Glad the accessibility things are merged 🙌. The now build command needs to be updated and point to the new build:

https://zeit.co/miukimiu/react-kawaii/settings (I think)

To this:

npm ci && npm run now-build
build
npm ci && npm run styleguide